Skip to content

Pp comments #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Pp comments #251

wants to merge 6 commits into from

Conversation

toku-sa-n
Copy link
Owner

@toku-sa-n toku-sa-n commented Sep 19, 2023

Closes: #256

@toku-sa-n
Copy link
Owner Author

Pcoq.Parsable.comments always returns an empty list, and I don't know how to retrieve comments.

@BridgeTheMasterBuilder
Copy link
Contributor

I have not investigated this very deeply but I did dig around in the Coq source code for a while and eventually found this in gramlib/plexing.mli

  (* State for the comments, at some point we should make it functional *)
  module State : sig
    type t
    val init : unit -> t
    val set : t -> unit
    val get : unit -> t
    val drop : unit -> unit
    val get_comments : t -> ((int * int) * string) list
  end

So... possibly it's a TODO? I honestly am not sure yet how to verify whether or not it stores comments, maybe it's worth opening an issue on the Coq GitHub inquiring about this. Maybe they just haven't gotten around to it because nobody needed this feature (until now).

@toku-sa-n
Copy link
Owner Author

I sent a question to Coq's Zulip.

@toku-sa-n
Copy link
Owner Author

@BridgeTheMasterBuilder
Copy link
Contributor

Answer: Flags.beautify := true

Awesome! Didn't expect an answer so soon.

@toku-sa-n toku-sa-n added the help wanted Extra attention is needed label Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pp comments
2 participants