Skip to content

Conversation

@TannerRogalsky
Copy link
Contributor

@TannerRogalsky TannerRogalsky commented Nov 29, 2023

The internals of the various components of this example have changed significantly. While this works, I'd appreciate a careful review to ensure that it is correct in addition to functional.

Thank you!

@mcches mcches requested a review from LucioFranco November 29, 2023 14:59
@FrankReh
Copy link

👍 I can't offer a review but it's nice to see the code necessary for Hyper 1 and I can offer it compiled and ran on my Linux 6.2 machine.

@TannerRogalsky
Copy link
Contributor Author

The hyper-util dependency has been updated to the most recent release. I believe this is good to merge now baring any review change requests.

@getong
Copy link

getong commented Dec 28, 2023

@TannerRogalsky
How about taking a look at the grpc example, which might be updated too?

@TannerRogalsky
Copy link
Contributor Author

@getong I'm not interested in doing that but you should be able to use my code an example of the things that need to change.

@getong
Copy link

getong commented Dec 28, 2023

@getong I'm not interested in doing that but you should be able to use my code an example of the things that need to change.

I am willing to do this, I tried but failed, I does not know how to fix it.

@seanmonstar seanmonstar merged commit b46f60e into tokio-rs:main Jan 10, 2024
@TannerRogalsky TannerRogalsky deleted the update_axum_example branch January 10, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants