opentelemetry: Connect external traces #956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Motivation There are cases where an `opentelemetry` span will be created before a `tracing` span (e.g. some server middleware). In this case it would be helpful for `tracing-opentelemetry` to connect generated spans to the existing trace rather than starting a new trace. ## Solution If a parent trace id does not exist, check the current otel context and only generate a new trace id if no valid id is found.
jtescher
added
the
crate/opentelemetry
LucioFranco
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are cases where an
opentelemetryspan will be created before atracingspan (e.g. some server middleware). In this case it would be helpful fortracing-opentelemetryto connect generated spans to the existing trace rather than starting a new trace.Solution
If a parent trace id does not exist, check the current otel context and only generate a new trace id if no valid id is found.