Value implementation for `Option<T> where T: Value
#878
Conversation
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
fix lifetime mismatch
akshatagarwl
changed the title
implementation for Option<T> where T: ValueValue implementation for `Option<T> where T: Value
tracing-core/src/field.rs
Outdated
| /// Visit an Option | ||
| fn record_option(&mut self, field: &Field, value: Option<&(dyn Value + 'static)>) { | ||
| if let Some(inner_value) = value { | ||
| self.record_debug(field, &inner_value) |
There was a problem hiding this comment.
I don't think this implements the recording of the interior type using the appropriate type-specific record_* method as described in the linked task.
You probably want to call the record method on the inner_value.
There was a problem hiding this comment.
Is this right inner_value.record(field, self)?
There was a problem hiding this comment.
Is this right
inner_value.record(field, self)?
Yeah, that's right.
| /// Visit an Option | ||
| fn record_option(&mut self, field: &Field, value: Option<&(dyn Value + 'static)>) | ||
| where | ||
| Self: std::marker::Sized, |
There was a problem hiding this comment.
You don't want to have a Self: Sized constraint here because this trait is meant to be used with dynamic dispatch.
If you added it because of the borrow checker try using a reborrow (&mut *self) to pass self to inner_value.record().
| if let Some(inner_value) = value { | ||
| inner_value.record(field, self) | ||
| } else { | ||
| } |
There was a problem hiding this comment.
Can this else { } be removed if we aren't going to do anything with it? If a serializer cares about the lack of a value they can always override this method and do a match themselves.
|
Thanks! @Michael-F-Bryan |
|
Obsoleted by #1585, sorry about that! |
Closes #824