fix macro path #740
Merged
fix macro path #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
hawkw
approved these changes
May 29, 2020
There was a problem hiding this comment.
Thanks, now that we're using $crate rather than local_inner_macros, I believe it's correct to change these macros as well.
As a side note, I believe this should fix the issues that have occurred when using the "log" feature flag when the tracing crate has been renamed in Cargo.toml.
|
Great ! Do you know when it will be merged ? |
Sorry, my bad! I meant to merge this as soon as CI passed, but I think I must've forgot. It's merged now. Thanks again for the fix! |
hawkw
added a commit
that referenced
this pull request
Jun 3, 2020
# 0.1.15 (June 2, 2020) ### Changed - **macros**: Replaced use of legacy `local_inner_macros` with `$crate::` (#740) ### Added - Docs fixes and improvements (#742, #731, #730) Thanks to @bnjjj, @blaenk, and @LukeMathWalker for contributing to this release! Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Hello 👋 ! I had some issues playing with tracing and event! macro due to a call to a macro prefixed by
tracing::so I fixed with$crate::like it's done for all other macros :)