chore: run tracing-subscriber tests with all features
#3412
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hds
force-pushed
the
hds/subscriber-test-all-features
branch
3 times, most recently
from
7d67965 to
c816f02
Compare
While investigating #3405, we found that some tests are not being run on CI. Specifically the `tracing-subscriber` tests that depend on non-default features. This change adds 2 new `run` commands to the `test-features-stable` CI job, one with `nextest` and another for the doc tests. There is also 1 more `run` command to run the `tracing-mock` tests with all features (which is just `tracing-subscriber` right now, but safer to set all).
hds
force-pushed
the
hds/subscriber-test-all-features
branch
from
c816f02 to
14e7275
Compare
djc
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While investigating #3405, we found that some tests are not being run on
CI. Specifically the
tracing-subscribertests that depend onnon-default features.
Solution
This change adds 2 new
runcommands to thetest-features-stableCIjob, one with
nextestand another for the doc tests.There is also 1 more
runcommand to run thetracing-mocktests withall features (which is just
tracing-subscriberright now, but safer toset all).