feat(subscriber): Add with_span_list implementation for all standard formats. #3397
+122
−83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As a "out-of-the-box" subscribers user, I want to be able to skip formatting of parent spans not only in Json formatter implementation, but also for Full, Pretty and Compact.
I discovered that one PR was made with attempt to add these implementations: #3357 (unfortunately it wasn't finished), and there was an issue asking for such functionality: #2805
As I see, such implementations are wanted by community, that's why I decided to contribute them.
Solution
Solution is simple and straightforward - I extracted
display_span_listboolean flag from Json formatter to mainFormatstruct which later used in allFormatEventtrait implementations.