Skip to content

Conversation

@humb1t
Copy link

@humb1t humb1t commented Oct 27, 2025

Motivation

As a "out-of-the-box" subscribers user, I want to be able to skip formatting of parent spans not only in Json formatter implementation, but also for Full, Pretty and Compact.

I discovered that one PR was made with attempt to add these implementations: #3357 (unfortunately it wasn't finished), and there was an issue asking for such functionality: #2805

As I see, such implementations are wanted by community, that's why I decided to contribute them.

Solution

Solution is simple and straightforward - I extracted display_span_list boolean flag from Json formatter to main Format struct which later used in all FormatEvent trait implementations.

@humb1t humb1t force-pushed the with_span_list_for_all_formats branch from 13c5c56 to 52236aa Compare October 27, 2025 11:53
@humb1t humb1t force-pushed the with_span_list_for_all_formats branch from 52236aa to 1a095ff Compare October 27, 2025 13:32
@humb1t humb1t marked this pull request as ready for review October 27, 2025 13:32
@humb1t humb1t requested review from a team and hawkw as code owners October 27, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant