-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracing: add index API for Field
#2820
Open
Rustin170506
wants to merge
2
commits into
tokio-rs:master
Choose a base branch
from
Rustin170506:rustin-patch-field-index
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
tracing: add index API for Field
#2820
Rustin170506
wants to merge
2
commits into
tokio-rs:master
from
Rustin170506:rustin-patch-field-index
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hds
requested changes
Nov 29, 2023
Rustin170506
force-pushed
the
rustin-patch-field-index
branch
from
December 2, 2023 02:18
f3f558e
to
1bc36ea
Compare
Rustin170506
commented
Dec 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔢 Self-check
hds
reviewed
Dec 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good to me, but I'd like @hawkw to review.
Rustin170506
force-pushed
the
rustin-patch-field-index
branch
2 times, most recently
from
January 29, 2024 12:29
0ff46c2
to
667dbcb
Compare
@hawkw Friendly ping~ |
Rustin170506
force-pushed
the
rustin-patch-field-index
branch
from
March 28, 2024 15:06
667dbcb
to
1db2c84
Compare
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Rustin170506
force-pushed
the
rustin-patch-field-index
branch
from
May 7, 2024 10:09
1db2c84
to
a26438d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Expose the index of the field. See more at: tokio-rs/console#462 (comment)
Solution
Just added a new API.