subscriber: fix LocalTime being re-exported by the time feature
#1685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `pub use` re-export for the `LocalTime` struct is enabled whenever the "time" feature flag is enabled. However, this type only _exists_ when the "local-time" feature flag is enabled, so enabling only the `time` feature results in a compilation error. This commit adds a separate `pub use` for `LocalTime` that's only enabled when the "local-time" feature is enabled. Fixes #1683
davidbarsky
approved these changes
Oct 25, 2021
hawkw
added a commit
that referenced
this pull request
Oct 25, 2021
…1685) ## Motivation Currently, the `pub use` re-export for the `LocalTime` struct is enabled whenever the "time" feature flag is enabled. However, this type only _exists_ when the "local-time" feature flag is enabled, so enabling only the `time` feature results in a compilation error. ## Solution This commit adds a separate `pub use` for `LocalTime` that's only enabled when the "local-time" feature is enabled. Fixes #1683
hawkw
added a commit
that referenced
this pull request
Oct 25, 2021
# 0.3.1 (Oct 25, 2021) This release fixes a few issues related to feature flagging. ### Fixed - **time**: Compilation error when enabling the "time" feature flag without also enabling the "local-time" feature flag ([#1685]) - **registry**: Unused method warnings when the "std" feature is enabled but the "registry" feature is disabled ([#1686]) [#1685]: #1685 [#1686]: #1686
hawkw
added a commit
that referenced
this pull request
Oct 25, 2021
# 0.3.1 (Oct 25, 2021) This release fixes a few issues related to feature flagging. ### Fixed - **time**: Compilation error when enabling the "time" feature flag without also enabling the "local-time" feature flag ([#1685]) - **registry**: Unused method warnings when the "std" feature is enabled but the "registry" feature is disabled ([#1686]) [#1685]: #1685 [#1686]: #1686
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
# 0.3.1 (Oct 25, 2021) This release fixes a few issues related to feature flagging. ### Fixed - **time**: Compilation error when enabling the "time" feature flag without also enabling the "local-time" feature flag ([tokio-rs#1685]) - **registry**: Unused method warnings when the "std" feature is enabled but the "registry" feature is disabled ([tokio-rs#1686]) [tokio-rs#1685]: tokio-rs#1685 [tokio-rs#1686]: tokio-rs#1686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the
pub usere-export for theLocalTimestruct is enabledwhenever the "time" feature flag is enabled. However, this type only
exists when the "local-time" feature flag is enabled, so enabling only
the
timefeature results in a compilation error.Solution
This commit adds a separate
pub useforLocalTimethat's onlyenabled when the "local-time" feature is enabled.
Fixes #1683