chore(ci): turn off fail-fast for some build matrix jobs
#1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default behavior for GitHub Actions `matrix` strategies is to cancel all remaining jobs in a `matrix` job if *any* of them fail. However, this sometimes obscures important information. For example, we have a step that runs tests on stable, beta, and nightly Rust. In this case, it's useful to know whether a failure occurred only on nightly, or if it effects *every* Rust version. Furthermore, our branch protection settings don't require the nightly build to pass in order to merge a PR, because there are sometimes spurious failures due to nightly-specific bugs. We *do* require the stable build to pass. However, because the `matrix` strategy will cancel all jobs in the matrix if any of them fails, this means that we implicitly *do* require the tests to pass on nightly, as if the nightly job fails, it will also cancel the required stable job. This commit updates the github actions config to disable failfast for some build matrices.
hawkw
added a commit
that referenced
this pull request
Sep 4, 2021
The default behavior for GitHub Actions `matrix` strategies is to cancel all remaining jobs in a `matrix` job if *any* of them fail. However, this sometimes obscures important information. For example, we have a step that runs tests on stable, beta, and nightly Rust. In this case, it's useful to know whether a failure occurred only on nightly, or if it effects *every* Rust version. Furthermore, our branch protection settings don't require the nightly build to pass in order to merge a PR, because there are sometimes spurious failures due to nightly-specific bugs. We *do* require the stable build to pass. However, because the `matrix` strategy will cancel all jobs in the matrix if any of them fails, this means that we implicitly *do* require the tests to pass on nightly, as if the nightly job fails, it will also cancel the required stable job. This commit updates the github actions config to disable failfast for some build matrices.
hawkw
added a commit
that referenced
this pull request
Sep 4, 2021
The default behavior for GitHub Actions `matrix` strategies is to cancel all remaining jobs in a `matrix` job if *any* of them fail. However, this sometimes obscures important information. For example, we have a step that runs tests on stable, beta, and nightly Rust. In this case, it's useful to know whether a failure occurred only on nightly, or if it effects *every* Rust version. Furthermore, our branch protection settings don't require the nightly build to pass in order to merge a PR, because there are sometimes spurious failures due to nightly-specific bugs. We *do* require the stable build to pass. However, because the `matrix` strategy will cancel all jobs in the matrix if any of them fails, this means that we implicitly *do* require the tests to pass on nightly, as if the nightly job fails, it will also cancel the required stable job. This commit updates the github actions config to disable failfast for some build matrices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behavior for GitHub Actions
matrixstrategies is to cancelall remaining jobs in a
matrixjob if any of them fail. However,this sometimes obscures important information. For example, we have a
step that runs tests on stable, beta, and nightly Rust. In this case,
it's useful to know whether a failure occurred only on nightly, or if it
effects every Rust version.
Furthermore, our branch protection settings don't require the nightly
build to pass in order to merge a PR, because there are sometimes
spurious failures due to nightly-specific bugs. We do require the
stable build to pass. However, because the
matrixstrategy will cancelall jobs in the matrix if any of them fails, this means that we
implicitly do require the tests to pass on nightly, as if the nightly
job fails, it will also cancel the required stable job.
This commit updates the github actions config to disable failfast for
some build matrices.