core: make Level and LevelFilter Hash #1456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
approved these changes
Aug 6, 2021
Member
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
👍 I see no real reason why these shouldn't be Hash, thanks!
hawkw
added a commit
that referenced
this pull request
Aug 17, 2021
Fixes: #1376 Co-authored-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Aug 17, 2021
Fixes: #1376 Co-authored-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Aug 17, 2021
# 0.1.19 (August 17, 2021) ### Added - `Level::as_str` ([#1413]) - `Hash` implementation for `Level` and `LevelFilter` ([#1456]) - `Value` implementation for `&mut T where T: Value` ([#1385]) - Multiple documentation fixes and improvements ([#1435], [#1446]) Thanks to @Folyd, @teozkr, and @dvdplm for contributing to this release! [#1413]: #1413 [#1456]: #1456 [#1385]: #1385 [#1435]: #1435 [#1446]: #1446 Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Aug 17, 2021
# 0.1.19 (August 17, 2021) ### Added - `Level::as_str` ([#1413]) - `Hash` implementation for `Level` and `LevelFilter` ([#1456]) - `Value` implementation for `&mut T where T: Value` ([#1385]) - Multiple documentation fixes and improvements ([#1435], [#1446]) Thanks to @Folyd, @teozkr, and @dvdplm for contributing to this release! [#1413]: #1413 [#1456]: #1456 [#1385]: #1385 [#1435]: #1435 [#1446]: #1446 Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
added a commit
that referenced
this pull request
Aug 17, 2021
# 0.1.19 (August 17, 2021) ### Added - `Level::as_str` ([#1413]) - `Hash` implementation for `Level` and `LevelFilter` ([#1456]) - `Value` implementation for `&mut T where T: Value` ([#1385]) - Multiple documentation fixes and improvements ([#1435], [#1446]) Thanks to @Folyd, @teozkr, and @dvdplm for contributing to this release! [#1413]: #1413 [#1456]: #1456 [#1385]: #1385 [#1435]: #1435 [#1446]: #1446 Signed-off-by: Eliza Weisman <eliza@buoyant.io>
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
# 0.1.19 (August 17, 2021) ### Added - `Level::as_str` ([tokio-rs#1413]) - `Hash` implementation for `Level` and `LevelFilter` ([tokio-rs#1456]) - `Value` implementation for `&mut T where T: Value` ([tokio-rs#1385]) - Multiple documentation fixes and improvements ([tokio-rs#1435], [tokio-rs#1446]) Thanks to @Folyd, @teozkr, and @dvdplm for contributing to this release! [tokio-rs#1413]: tokio-rs#1413 [tokio-rs#1456]: tokio-rs#1456 [tokio-rs#1385]: tokio-rs#1385 [tokio-rs#1435]: tokio-rs#1435 [tokio-rs#1446]: tokio-rs#1446 Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1376