Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing-fmt: example out of date #444

Closed
EverlastingBugstopper opened this issue Nov 21, 2019 · 1 comment · Fixed by #671
Closed

tracing-fmt: example out of date #444

EverlastingBugstopper opened this issue Nov 21, 2019 · 1 comment · Fixed by #671
Labels
crate/subscriber Related to the `tracing-subscriber` crate

Comments

@EverlastingBugstopper
Copy link

Bug Report

Version

├── tracing v0.1.10
│   ├── tracing-attributes v0.1.5
│   └── tracing-core v0.1.7
└── tracing-subscriber v0.2.0-alpha.1
    ├── tracing-core v0.1.7 (*)
    ├── tracing-log v0.1.1
    │   └── tracing-core v0.1.7 (*)
    └── tracing-serde v0.1.0
        └── tracing-core v0.1.7 (*)
    └── tracing-log v0.1.1 (*)

Platform

Darwin C02VM0JPHTDD 18.7.0 Darwin Kernel Version 18.7.0: Thu Jun 20 18:42:21 PDT 2019; root:xnu-4903.270.47~4/RELEASE_X86_64 x86_64

Crates

tracing-fmt
tracing-subscriber

Description

I tried copy and pasting this file into a new cargo project and adding tracing, tracing-subscriber and tracing-fmt to my Cargo.toml but it would not compile.

Existing example use statements


use tracing_fmt::format;
use tracing_subscriber::prelude::*;

Proposed use statements


use tracing_subscriber::fmt::format;
use tracing_subscriber::prelude::*;
use tracing_subscriber::FmtSubscriber;
@hawkw
Copy link
Member

hawkw commented Nov 21, 2019

Thanks! I think the example should also be moved to https://github.com/tokio-rs/tracing/tree/master/examples/examples

@hawkw hawkw added the crate/subscriber Related to the `tracing-subscriber` crate label Nov 26, 2019
@hawkw hawkw closed this as completed in #671 Apr 7, 2020
hawkw added a commit that referenced this issue Apr 7, 2020
This example is outdated and should have been removed when `tracing-fmt`
was merged into `tracing-subscriber`. There is another example in the
`examples` crate, [`fmt-custom-fields`][1], which demonstrates the same
usage, but uses the current APIs. Therefore, we can just delete the old
example.

[1]: https://github.com/tokio-rs/tracing/blob/master/examples/examples/fmt-custom-field.rs

Fixes: #444

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate/subscriber Related to the `tracing-subscriber` crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants