-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The provenance of tracing-subscriber/src/fmt/time/datetime.rs appears to be troubled #1644
Comments
Copying the code from Because it was Dan's suggestion, I didn't take the time to double-check that the two projects were compatibly licensed. My bad. |
My opinion (and I'm far from having a sophisticated understanding of copyright) is that |
Thanks for fixing @krasimirgg. This has got me thinking, this code is now copied into tracing which itself is a dependency of |
(I also cringe that the 'heart attack' comment has survived for like 5 years, and is on track to survive an indefinite amount of time longer) |
Thank you for updating the 0.3 version! Could you also cherry pick this into the 0.2.x version of the crate over at crates.io if possible? This will be handy since the 0.2.x version is still a dependency of some rustc components and of tracing-tree, which is itself a rustc dependency. |
@krasimirgg i suspect that it's going to be somewhat painful for us to update 0.2. I can, however, spend some time on updating |
This sounds good! It would leave us with just the rustc_driver (and some additional rustc tools) that directly depend on |
Bug Report
Version
Crate tracing-subscriber, AFAICT versions since 56b841d, including the current master branch.
Description
The provenance of the code in datetime.rs appears to be troubled: per comments on code etc, it appears to have started as musl code (MIT license), gone through c2rust and been given manual edits (those edits in the scope of an Apache-2.0 licensed project, so presumably those edits are Apache-2.0), and then been copied into this codebase as MIT. Could we replace that code with something that has a clearly MIT-licensed provenance, or switch this package to explicitly be MIT AND Apache-2.0 licensing?
tracing/tracing-subscriber/src/fmt/time/datetime.rs
Line 16 in 56b841d
The text was updated successfully, but these errors were encountered: