fs: emit compilation error without tokio_unstable for io-uring
#7634
+75
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADD-SP
changed the title
tokio_unstable for io-uring
ADD-SP
force-pushed
the
add_sp/fs-emit-compile-error
branch
18 times, most recently
from
a579578 to
d0c7c35
Compare
ADD-SP
commented
Sep 20, 2025
| /// panic!("This panic will shutdown the runtime."); | ||
| /// }).await; | ||
| /// } | ||
| /// # #[cfg(not(tokio_unstable))] |
There was a problem hiding this comment.
I removed it due to this
Click to see the image
ADD-SP
commented
Sep 20, 2025
| /// }).await; | ||
| /// }) | ||
| /// } | ||
| /// # #[cfg(not(tokio_unstable))] |
There was a problem hiding this comment.
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
ADD-SP
force-pushed
the
add_sp/fs-emit-compile-error
branch
from
d0c7c35 to
33c603b
Compare
|
Sorry for the delay, I'll check this tomorrow. |
mox692
approved these changes
Sep 24, 2025
.github/workflows/ci.yml
Outdated
Comment on lines
339
to
351
| cargo nextest run --all-features | ||
| cargo test --doc --all-features | ||
| # taskdump is an unstable feature, but it can only be enabled | ||
| # by --cfg tokio_taskdump, not by a feature flag, so we can | ||
| # use $TOKIO_STABLE_FEATURES here. | ||
| cargo nextest run --features $TOKIO_STABLE_FEATURES | ||
| cargo test --doc --features $TOKIO_STABLE_FEATURES |
There was a problem hiding this comment.
Does this part really use the taskdump feature?
Comment on lines
-783
to
+802
| - name: "clippy --all ${{ matrix.rustflags }}" | ||
| run: cargo clippy --all --tests --all-features --no-deps | ||
| - name: "clippy --all --features ${{ env.TOKIO_STABLE_FEATURES }}" | ||
| run: cargo clippy --all --tests --no-deps --features $TOKIO_STABLE_FEATURES | ||
| - name: "clippy --all --all-features --unstable" | ||
| run: cargo clippy --all --tests --no-deps --all-features | ||
| env: | ||
| RUSTFLAGS: ${{ matrix.rustflags }} | ||
| RUSTFLAGS: --cfg tokio_unstable --cfg tokio_taskdump -Dwarnings |
There was a problem hiding this comment.
If I understand correctly, this change removed the case where we don't use tokio_unstable?
There was a problem hiding this comment.
There is a cargo cliipy in the near above, did you mean this?
- name: "clippy --all --features ${{ env.TOKIO_STABLE_FEATURES }}"
run: cargo clippy --all --tests --no-deps --features $TOKIO_STABLE_FEATURESSigned-off-by: ADD-SP <qiqi.zhang@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixup of #7621 for better error message. Otherwise, the error message is a bit encrypted.
This is a bit complicated. It seems like it's not worth the complexity, but we still have to do it because we also want to convert
--cfg tokio_taskdumpinto a Cargo feature, and taskdump already has similar user-friendly error messages.tokio/tokio/src/lib.rs
Lines 477 to 478 in 3b5a15d