sync: close the broadcast::Sender in broadcast::Sender::new()
#7629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
force-pushed
the
broadcast-sender-new-closed-true
branch
2 times, most recently
from
6a9bf27 to
3d3b8f4
Compare
…closed Sender::closed() should return Poll::Ready() if there are no receivers for this channel
martin-g
force-pushed
the
broadcast-sender-new-closed-true
branch
from
3d3b8f4 to
6398d6e
Compare
ADD-SP
changed the title
broadcast::Sender::new()
ADD-SP
changed the title
broadcast::Sender::new()broadcast::Sender by default in broadcast::Sender::new()
ADD-SP
changed the title
broadcast::Sender by default in broadcast::Sender::new()broadcast::Sender in broadcast::Sender::new()
Merged
Closed
ADD-SP
pushed a commit
to ADD-SP/tokio
that referenced
this pull request
Oct 14, 2025
…kio-rs#7629) (cherry picked from commit 6d1ae62)
ADD-SP
pushed a commit
to ADD-SP/tokio
that referenced
this pull request
Oct 14, 2025
…kio-rs#7629) (cherry picked from commit 6d1ae62)
ADD-SP
pushed a commit
to ADD-SP/tokio
that referenced
this pull request
Oct 14, 2025
…kio-rs#7629) (cherry picked from commit 6d1ae62)
Merged
ADD-SP
pushed a commit
that referenced
this pull request
Oct 14, 2025
) (cherry picked from commit 6d1ae62)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
tokio::sync::broadcast::Sender::closed() should return Poll::Ready if there are no receivers for the channel.
A newly created Sender with
Sender::new()currently returns Poll::Pending although there are no receivers for it.Solution
Initialize Tail::closed with
receivers_count == 0