net: clarify the supported platform of set_reuseport() and reuseport()
#7628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…euseaddr to list Cygwin as an excluded platform (matching the cfg gating).
ADD-SP
added
T-docs
ADD-SP
changed the title
set_reuseport() and reuseport()
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes documentation mismatches introduced by cfg changes that exclude Cygwin from certain unix-only APIs.
set_reuseportandreuseportexplicitly mention Cygwin alongside Solaris & Illumos.Rationale:
The implementation cfgs exclude Cygwin
(not(target_os = "cygwin")), but the prose still listed only Solaris & Illumos.That mismatch confuses users who attempt to compile for
*-pc-cygwin.This PR makes docstring consistent with the code.
No runtime or API changes are included here.