Add new tests for JoinSet, JoinMap, TaskTracer and LocalRuntime #7609
Conversation
ADD-SP
added
A-tokio-util
tokio/tests/task_join_set.rs
Outdated
| } | ||
|
|
||
| // Dropping a `JoinSet` created inside a **LocalRuntime** | ||
| // must abort every still-running `!Send` task that was |
There was a problem hiding this comment.
must abort every still-running
!Sendtask that was
Does Send or not matter?
There was a problem hiding this comment.
No, it doesn't. I will modify the comment removing " !Send "
ADD-SP
added
the
S-waiting-on-author
|
Hi @FrancescoV1985 , any update on this PR? |
|
| set.spawn_local_on(async move { *rc }, &local); | ||
| } | ||
|
|
||
| assert!(set.try_join_next().is_none()); |
There was a problem hiding this comment.
Actually, since we are using the single thread runtime and there is no yield point here, the set.try_join_next() is always None, we should rewrite this test.
| // Tasks are queued with `spawn_local_on` **before** the `LocalSet` is | ||
| // running, then executed once the `LocalSet` is started. | ||
| #[tokio::test(flavor = "current_thread")] | ||
| async fn spawn_local_on_on_started_localset() { |
There was a problem hiding this comment.
What's the difference between this test and spawn_local_on_local_runtime?
| for _ in 0..N { | ||
| let (tx, rx) = oneshot::channel::<()>(); | ||
| receivers.push(rx); | ||
| set.spawn_local(async move { | ||
| pending::<()>().await; | ||
| drop(tx); | ||
| }); | ||
| } |
There was a problem hiding this comment.
There are many duplicated code like this, could you try to improve this de-dup it?
| for rx in receivers { | ||
| assert!( | ||
| rx.await.is_err(), | ||
| "the task should have been aborted and the sender dropped" | ||
| ); | ||
| } |
There was a problem hiding this comment.
Could you try to de-dup this kind of code?
I committed the tests for TaskTracker. I still need to add comments and double check. I will pm you for some clarifications.. |
Fixes: #7562
Motivation
Improve the test coverage of task containers on LocalRuntime
Solution
Added new tests for JoinSet, JoinMap, TaskTracer