task: add `tokio_util::task::JoinQueue` #7590

nickkuk · 2025-09-08T16:54:45Z

New tokio_util::task::JoinQueue structure as FIFO-ordered analog of tokio::task::JoinSet.

Issue: #7576

Edit: renamed from JoinDeque to JoinQueue.

tokio-util/src/task/join_deque.rs

ADD-SP

I think we should replicate most of the methods from JoinSet.

nickkuk · 2025-09-10T19:52:58Z

I think we should replicate most of the methods from JoinSet.

Ok, I pushed implementation of all methods except try_join_next and try_join_next_with_id. Do you know how to implement them?

ADD-SP

Since this is not the double-ended queue, I would suggest change it to another name.

tokio-util/src/task/join_deque.rs

tokio-util/src/task/join_queue.rs

ADD-SP

Please avoid force-pushing during the review process.
Could you add tests for this feature?

nickkuk · 2025-09-15T20:40:17Z

@ADD-SP yes, added.

tokio-util/src/task/join_queue.rs

tokio-util/tests/task_join_queue.rs

tokio-util/src/task/join_queue.rs

tokio-util/tests/task_join_queue.rs

tokio-util/src/task/join_queue.rs

tokio-util/tests/task_join_queue.rs

nickkuk · 2025-09-18T14:59:46Z

It seems that now CI failed with errors unrelated to this PR's changes.

@ADD-SP should we restart CI, or should I update branch, or something else?

ADD-SP · 2025-09-18T15:04:53Z

It seems that now CI failed with errors unrelated to this PR's changes.

@ADD-SP should we restart CI, or should I update branch, or something else?

These failures are caused by the recent Rust release (Rust 1.90.0), you could update the branch after #7630 is merged.

ADD-SP

Overall looks good to me, @nickkuk Could you sync the changes from the base branch?

This reverts commit 070c209.

ADD-SP

Overall looks good to me.

tokio-util/src/task/join_queue.rs

This reverts commit dbdb56e.

ADD-SP

Thanks!

nickkuk mentioned this pull request Sep 8, 2025

New JoinDeque as FIFO-ordered analog of JoinSet #7576

Closed

nickkuk force-pushed the join_deque branch 3 times, most recently from 2068e58 to bab83ad Compare September 8, 2025 17:44

ADD-SP reviewed Sep 9, 2025

View reviewed changes

tokio-util/src/task/join_deque.rs Outdated Show resolved Hide resolved

ADD-SP reviewed Sep 9, 2025

View reviewed changes

tokio-util/src/task/join_deque.rs Outdated Show resolved Hide resolved

ADD-SP added C-enhancement Category: A PR with an enhancement or bugfix. A-tokio-util Area: The tokio-util crate M-task Module: tokio/task labels Sep 9, 2025

nickkuk force-pushed the join_deque branch from bab83ad to 6756ee4 Compare September 9, 2025 07:15

ADD-SP reviewed Sep 10, 2025

View reviewed changes

ADD-SP added the S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. label Sep 10, 2025

nickkuk force-pushed the join_deque branch 2 times, most recently from 2c34aef to 837875d Compare September 10, 2025 19:50

nickkuk requested a review from ADD-SP September 10, 2025 20:04

ADD-SP reviewed Sep 11, 2025

View reviewed changes

tokio-util/src/task/join_deque.rs Outdated Show resolved Hide resolved

tokio-util/src/task/join_deque.rs Outdated Show resolved Hide resolved

nickkuk force-pushed the join_deque branch from 837875d to f2bf49d Compare September 11, 2025 08:14

nickkuk changed the title ~~util: add JoinDeque structure~~ util: add JoinQueue data structure Sep 11, 2025

nickkuk force-pushed the join_deque branch from f2bf49d to abe4268 Compare September 11, 2025 08:16

Darksonn reviewed Sep 11, 2025

View reviewed changes

tokio-util/src/task/join_queue.rs Show resolved Hide resolved

tokio-util/src/task/join_queue.rs Outdated Show resolved Hide resolved

nickkuk force-pushed the join_deque branch from abe4268 to 413ce71 Compare September 11, 2025 10:57

ADD-SP reviewed Sep 15, 2025

View reviewed changes

ADD-SP reviewed Sep 16, 2025

View reviewed changes

tokio-util/src/task/join_queue.rs Show resolved Hide resolved

tokio-util/src/task/join_queue.rs Show resolved Hide resolved

tokio-util/tests/task_join_queue.rs Show resolved Hide resolved

ADD-SP reviewed Sep 16, 2025

View reviewed changes

tokio-util/src/task/join_queue.rs Outdated Show resolved Hide resolved

tokio-util/src/task/join_queue.rs Outdated Show resolved Hide resolved

tokio-util/src/task/join_queue.rs Outdated Show resolved Hide resolved

tokio-util/src/task/join_queue.rs Outdated Show resolved Hide resolved

ADD-SP reviewed Sep 17, 2025

View reviewed changes

tokio-util/src/task/join_queue.rs Show resolved Hide resolved

tokio-util/tests/task_join_queue.rs Outdated Show resolved Hide resolved

tokio-util/tests/task_join_queue.rs Show resolved Hide resolved

tokio-util/tests/task_join_queue.rs Outdated Show resolved Hide resolved

ADD-SP reviewed Sep 17, 2025

View reviewed changes

tokio-util/src/task/join_queue.rs Show resolved Hide resolved

ADD-SP removed the S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. label Sep 17, 2025

ADD-SP reviewed Sep 18, 2025

View reviewed changes

tokio-util/src/task/join_queue.rs Outdated Show resolved Hide resolved

tokio-util/tests/task_join_queue.rs Outdated Show resolved Hide resolved

tokio-util/tests/task_join_queue.rs Outdated Show resolved Hide resolved

tokio-util/tests/task_join_queue.rs Outdated Show resolved Hide resolved

ADD-SP reviewed Sep 19, 2025

View reviewed changes

nickkuk added 8 commits September 19, 2025 18:11

util: add JoinQueue data structure

aaaa778

util: add no spurious wakeups test for JoinQueue

a60d3e5

util: fix JoinQueue documentation nits

f69c730

util: add more JoinQueue tests

e7d7c74

util: elaborate tests and comments for JoinQueue

9152f65

util: remove explicit drop in JoinQueue implementation

eab188e

Revert "util: remove explicit drop in JoinQueue implementation"

a863bbe

This reverts commit 070c209.

util: apply some fixes to JoinQueue documentation and tests

3ec00c4

nickkuk force-pushed the join_deque branch from a2816df to 3ec00c4 Compare September 19, 2025 16:11

ADD-SP approved these changes Sep 20, 2025

View reviewed changes

tokio-util/src/task/join_queue.rs Show resolved Hide resolved

nickkuk added 2 commits September 20, 2025 09:14

util: derive Default for JoinQueue

dbdb56e

Revert "util: derive Default for JoinQueue"

b78a1f4

This reverts commit dbdb56e.

ADD-SP approved these changes Sep 20, 2025

View reviewed changes

ADD-SP changed the title ~~util: add JoinQueue data structure~~ task: add tokio_util::task::JoinQueue Sep 20, 2025

ADD-SP merged commit 1b98d5a into tokio-rs:master Sep 20, 2025
89 checks passed

Uh oh!

Uh oh!

task: add tokio_util::task::JoinQueue #7590

task: add tokio_util::task::JoinQueue #7590

Uh oh!

Conversation

nickkuk commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ADD-SP left a comment

Choose a reason for hiding this comment

Uh oh!

nickkuk commented Sep 10, 2025

Uh oh!

ADD-SP left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ADD-SP left a comment

Choose a reason for hiding this comment

Uh oh!

nickkuk commented Sep 15, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nickkuk commented Sep 18, 2025

Uh oh!

ADD-SP commented Sep 18, 2025

Uh oh!

ADD-SP left a comment

Choose a reason for hiding this comment

Uh oh!

ADD-SP left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ADD-SP left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

task: add `tokio_util::task::JoinQueue` #7590

task: add `tokio_util::task::JoinQueue` #7590

nickkuk commented Sep 8, 2025 •

edited

Loading