task: clarify task ID reuse guarantees #7577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
R-loom-current-thread
OxleyS
force-pushed
the
id-guarantee-docs
branch
from
6cda501 to
81bb526
Compare
ADD-SP
added
T-docs
ADD-SP
reviewed
Sep 7, 2025
ADD-SP
removed
R-loom-current-thread
ADD-SP
changed the title
|
Thanks for the review comments, I'll start revising. Edit: Oh no, Github added the loom labels again 😄 Is there a way I can avoid that? |
github-actions
bot
added
R-loom-current-thread
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7553
As discussed in the above issue, we have an implicit guarantee that a task ID is not reused until both the task finishes and its
JoinHandleis joined on or dropped. User code requires this guarantee to do useful things with the ID, so this PR updates docs to make it more explicit.I chose the wording "joined on" to cover cases outside of plain
.await. In particular, joining a task via&mut JoinHandle(e.g.tokio::select!) counts for all intents and purposes, despite not strictly consuming theJoinHandle.