Skip to content

ci: Run Loom tests for tokio-util #7522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ci: Run Loom tests for tokio-util #7522

wants to merge 1 commit into from

Conversation

@404salad
Copy link

@404salad 404salad commented Aug 9, 2025

Adds a new CI job that runs Loom concurrency tests for the cancellation_token module in tokio-util. This job is triggered by the R-loom-sync-util label or on pushes to the main branches just like the other tests, fixes #7271

@404salad
ci: Run Loom tests for tokio-util
fd4646e 
Adds a new CI job that runs Loom concurrency tests for the `cancellation_token` module in `tokio-util`. This job is triggered by the `R-loom-sync-util` label or on pushes to the main branches just like the other tests, fixes tokio-rs#7271
@ADD-SP ADD-SP added A-ci Area: The continuous integration setup A-tokio-util Area: The tokio-util crate labels Aug 9, 2025
ADD-SP
ADD-SP reviewed Aug 9, 2025
View reviewed changes
Copy link
Member

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

This is not enough to run loom tests in CI. You could refer the loom tests section of CONTRIBUTING.md and test it locally, I believe this can help you a lot.

@ADD-SP ADD-SP added the S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. label Aug 12, 2025
@pepedinho
Copy link

@404salad Hey! Just checking in are you still working on this issue?

@404salad
Copy link
Author

@404salad Hey! Just checking in are you still working on this issue?

Hi! I’m tied up with some university work at the moment, so if you’d like to take over, please go ahead. I’ll close this PR.

@pepedinho
Copy link

@404salad Hey! Just checking in are you still working on this issue?

Hi! I’m tied up with some university work at the moment, so if you’d like to take over, please go ahead. I’ll close this PR.

Thanks for letting me know! I’d be happy to take over this issue.
Good luck with your university work!

@404salad 404salad closed this Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ADD-SP ADD-SP ADD-SP left review comments

Assignees

No one assigned

Labels

A-ci Area: The continuous integration setup A-tokio-util Area: The tokio-util crate S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Run loom test in tokio-util

3 participants

@404salad @pepedinho @ADD-SP