Skip to content

Conversation

WilliamVenner
Copy link
Contributor

Motivation

std::io::BufRead::skip_until was stabilized in Rust 1.83.0. Let's implement it into Tokio, too.

Solution

I have simply adapted existing read_until code to discard the read bytes rather than writing them in to a buffer.

@WilliamVenner WilliamVenner changed the title Implement skip_until io: Implement skip_until Jul 23, 2025
@ADD-SP
Copy link
Member

ADD-SP commented Jul 24, 2025

This breaks the MSRV, current MSRV is Rust 1.70, this requires 1.83.

@ADD-SP ADD-SP added A-tokio-util Area: The tokio-util crate A-tokio Area: The main tokio crate M-io Module: tokio/io C-enhancement Category: A PR with an enhancement or bugfix. S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. labels Jul 24, 2025
@mox692 mox692 added the S-blocked-on-msrv Status: need an MSRV bump to progress label Jul 28, 2025
@ADD-SP ADD-SP removed the S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. label Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate A-tokio-util Area: The tokio-util crate C-enhancement Category: A PR with an enhancement or bugfix. M-io Module: tokio/io S-blocked-on-msrv Status: need an MSRV bump to progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants