Skip to content

runtime: cleanup legacy tests of alt multi-threaded runtime #7451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025

Conversation

ADD-SP
Copy link
Member

@ADD-SP ADD-SP commented Jul 8, 2025

The alt multi-threaded runtime and relevant tests were initially added in #5823, and the alt multi-threaded runtime was removed in #7275.

However, there are two test combinations in tokio/tests/rt_common.rs that should have been deleted in #7275 were not.

Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
@ADD-SP ADD-SP added the A-tokio Area: The main tokio crate label Jul 8, 2025
@Darksonn
Copy link
Contributor

Darksonn commented Jul 8, 2025

Thanks. There is also:

loom-multi-thread-alt:
name: loom ALT multi-thread scheduler
# base_ref is null when it's not a pull request
if: github.repository_owner == 'tokio-rs' && (contains(github.event.pull_request.labels.*.name, 'R-loom-multi-thread-alt') || (github.base_ref == null))
runs-on: ubuntu-latest
strategy:
matrix:
include:
- scope: loom_multi_thread_alt::group_a
- scope: loom_multi_thread_alt::group_b
- scope: loom_multi_thread_alt::group_c
- scope: loom_multi_thread_alt::group_d
steps:
- uses: actions/checkout@v4
- name: Install Rust ${{ env.rust_stable }}
uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ env.rust_stable }}
- uses: Swatinem/rust-cache@v2
- name: loom ${{ matrix.scope }}
run: cargo test --lib --release --features full -- --nocapture $SCOPE
working-directory: tokio
env:
SCOPE: ${{ matrix.scope }}

Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
@ADD-SP ADD-SP merged commit 7dd4d8a into tokio-rs:master Jul 9, 2025
86 checks passed
@ADD-SP ADD-SP deleted the add_sp/remove-alt-rt-tests branch July 9, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants