Update backtrace #7295
Closed
Update backtrace #7295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed as the old versin of backtrace uses an old version of object, duplicating deps in my project. This version of backtrace has a MSRV of 1.65, which is lower than tokio.
Darksonn
reviewed
May 1, 2025
| @@ -106,7 +106,7 @@ tracing = { version = "0.1.29", default-features = false, features = ["std"], op | |||
| # Currently unstable. The API exposed by these features may be broken at any time. | |||
| # Requires `--cfg tokio_unstable` to enable. | |||
| [target.'cfg(tokio_taskdump)'.dependencies] | |||
| backtrace = { version = "0.3.58" } | |||
| backtrace = { version = "0.3.74" } | |||
There was a problem hiding this comment.
Tokio is already compatible with 0.3.74 with the current dependency specification. Why do we need to increase the minimum required version? I think you just need to update the lockfile in rust-gpu.
There was a problem hiding this comment.
That's a good question. I am tracking down why rustc includes 2 incompatible versions of object, and the old version of object is coming from crates that rely on backtrace < 0.3.74. There are three: anyhow, tokio, and eyer. It looks like it is eyer that is making it resolve to 0.3.71. I can close this.
Darksonn
added
A-tokio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed as the old version of backtrace uses an old version of object, duplicating deps in my project.
This version of backtrace has a MSRV of 1.65, which is lower than tokio.