Skip to content

Conversation

rex4539
Copy link

@rex4539 rex4539 commented Feb 1, 2025

No description provided.

@github-actions github-actions bot added R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-multi-thread-alt R-loom-sync Run loom sync tests on this PR R-loom-time-driver Run loom time driver tests on this PR labels Feb 1, 2025
@Darksonn Darksonn added the A-ci Area: The continuous integration setup label Feb 1, 2025
@Darksonn
Copy link
Contributor

Darksonn commented Feb 1, 2025

Which clippy warnings is this fixing? We already check for some clippy warnings based on this configuration:

rust_clippy: '1.77'

clippy:
name: clippy
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Install Rust ${{ env.rust_clippy }}
uses: dtolnay/rust-toolchain@stable
with:
toolchain: ${{ env.rust_clippy }}
components: clippy
- uses: Swatinem/rust-cache@v2
# Run clippy
- name: "clippy --all"
run: cargo clippy --all --tests --all-features --no-deps

@rex4539
Copy link
Author

rex4539 commented Feb 1, 2025

I ran cargo clippy --workspace --all-features and got numerous warnings, which I fixed.

@Darksonn
Copy link
Contributor

Darksonn commented Feb 5, 2025

If you make Tokio lint-free under a newer version of clippy than the one we check for right now, then please update the version number in the .github/ci folder so that it stays lint free under the new version.

@github-actions github-actions bot removed R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread-alt R-loom-multi-thread Run loom multi-thread tests on this PR labels Feb 5, 2025
@rex4539
Copy link
Author

rex4539 commented Feb 5, 2025

How do you want to handle this case?

error: the following explicit lifetimes could be elided: 'a
  --> tokio/tests/tcp_accept.rs:57:6
   |
57 | impl<'a> Stream for TrackPolls<'a> {
   |      ^^                        ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
   = note: `-D clippy::needless-lifetimes` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
   |
57 - impl<'a> Stream for TrackPolls<'a> {
57 + impl Stream for TrackPolls<'_> {
   |

Fix just this one case?

@Darksonn
Copy link
Contributor

Darksonn commented Feb 5, 2025

For TrackPolls you can apply the fix.

@rex4539 rex4539 closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration setup R-loom-sync Run loom sync tests on this PR R-loom-time-driver Run loom time driver tests on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants