ci: test AArch64/Armv7hf Linux on ubuntu-22.04-arm runner #7123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in github actions
taiki-e
commented
Jan 25, 2025
| env: | ||
| RUSTFLAGS: --cfg tokio_unstable -Dwarnings | ||
|
|
||
| cross-test-with-parking_lot: |
There was a problem hiding this comment.
Test for aarch64 is no longer "cross-test", but I leave it as is for now, the new runner is still in public preview, and if something goes wrong we can revert this PR with less-conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, we are testing
aarch64-unknown-linux-gnuandarmv7-unknown-linux-gnueabihfusing QEMU, but QEMU is slow than native execution.GitHub now supports free AArch64 Linux runners as public preview, so this PR use it for them.
Solution
As for
aarch64-unknown-linux-gnu, it is enough to change the OS to run on, and as forarmv7-unknown-linux-gnueabihf, it is necessary to change the OS to run on and install some additional packages, but the latter is handled by the setup-cross-toolchain-action currently already in use, so in practice it is also enough to change the OS to run on.(As for
armv5te-unknown-linux-gnueabi, Ubuntu does not provide packages forarmel, so unlikearmv7-unknown-linux-gnueabihf(armhf), we still need to use QEMU for now.)This PR also removes CircleCI config (
.circleci/config.yml) because native AArch64 test is now covered in GitHub Actions.Note that this PR uses
ubuntu-22.04-arminstead ofubuntu-24.04-armdue to upstream bug: rust-lang/rust#135867(I leaved TODO comments about it.)