Skip to content

fix: prevent optimize of try_lock in park.rs leading to race conditions (#6355) #6356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: prevent optimize of try_lock in park.rs leading to race conditions (#6355) #6356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tokio/src/runtime/scheduler/multi_thread/park.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ use crate::loom::sync::{Arc, Condvar, Mutex};
use crate::runtime::driver::{self, Driver};
use crate::util::TryLock;

use std::hint::black_box;
use std::sync::atomic::Ordering::SeqCst;
use std::time::Duration;

Expand Down Expand Up @@ -71,7 +72,7 @@ impl Parker {
// Only parking with zero is supported...
assert_eq!(duration, Duration::from_millis(0));

if let Some(mut driver) = self.inner.shared.driver.try_lock() {
if let Some(mut driver) = black_box(self.inner.shared.driver.try_lock()) {
driver.park_timeout(handle, duration);
}
}
Expand Down