Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: gate unwind tests and add ci step for tesing with panic=abort #6283

Merged
merged 7 commits into from
Jan 16, 2024
Merged

ci: gate unwind tests and add ci step for tesing with panic=abort #6283

merged 7 commits into from
Jan 16, 2024

Conversation

maminrayej
Copy link
Member

Verifies that all tests pass with panic=abort by adding a step to CI. Also, gates tests that need unwinding with #[cfg(panic = "unwind")].

Resolves #6109.

@Darksonn Darksonn added the A-ci Area: The continuous integration setup label Jan 14, 2024
Darksonn
Darksonn reviewed Jan 14, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
tokio/tests/io_panic.rs Show resolved Hide resolved
@maminrayej maminrayej requested a review from Darksonn January 14, 2024 14:58
@Darksonn Darksonn requested a review from taiki-e January 14, 2024 15:23
taiki-e
taiki-e reviewed Jan 14, 2024
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appear to be a lot of unused_imports/dead_code warnings.
We may want to use #[cfg_attr(panic = "abort", ignore)] instead of using #[cfg(panic = "unwind")] on the function.

tokio/tests/io_panic.rs Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
maminrayej and others added 2 commits January 14, 2024 22:35
@maminrayej @taiki-e
Update .github/workflows/ci.yml
001907a 
Co-authored-by: Taiki Endo <te316e89@gmail.com>
@maminrayej
make gates more consistent
043598b
@maminrayej maminrayej requested a review from taiki-e January 14, 2024 19:21
@Darksonn Darksonn merged commit 58edfc6 into tokio-rs:master Jan 16, 2024
74 checks passed
@maminrayej maminrayej mentioned this pull request Jan 30, 2024
Merged
@maminrayej maminrayej deleted the gate-unwind-tests branch January 18, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

@Darksonn Darksonn Awaiting requested review from Darksonn

Assignees
No one assigned
Labels
A-ci Area: The continuous integration setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify that all tests pass with panic=abort
3 participants
@maminrayej @Darksonn @taiki-e