More general interface for UdpFramed
#5969
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
UdpFramed
only accepted smart pointers toUdpSocket
. This commit changes it to accept anything that has.poll_recv_from()
and.poll_send_to()
. It allows for easier testing and more composability.Motivation
My specific usecase is the following: I have a wrapper for
UdpSocket
that records some low-level metrics. It’s impossible to do so on a higher level (i.e. wrappingUdpFramed
), because it requires basically replacing.poll_recv()
with different syscalls. I still want to re-use framing logic, but I need to pass a different type to it.UdpFramed
also doesn’t allow to pass a mock implementation for testing.Solution
I added new traits for sending / receiving datagrams and relaxed the requirements of
UdpFramed
to make it use these traits.Design notes
udp/
, because the interface is really specific. Unix sockets have similar APIs, but use paths instead of socket addrs.&mut self
instead of&self
to make external implementations easier.