timer: Reduce size of Delay struct
#554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that a better indicator of whether or not the number of active timeouts should be decremented is if the `Entry` has been associated with a timer. In other words, if `Entry::inner` can be upgraded, then the count should be decremented on drop.
This tweaks the struct layout / details regarding how a `Delay` instance is linked to a driver (timer instance). Instead of lazily allocating the `Entry` (node shared between `Delay` and the timer), `Entry` is allocated immediately when `Delay` is created. This allows using the entry store data used by `Delay`. This is in anticipation of further timer improvements that would otherwise require the size of `Delay` to grow further. Since an allocation is already made, the idea is to shrink the size of the `Delay` struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks the struct layout / details regarding how a
Delayinstanceis linked to a driver (timer instance). Instead of lazily allocating the
Entry(node shared betweenDelayand the timer),Entryisallocated immediately when
Delayis created. This allows using theentry store data used by
Delay.This is in anticipation of further timer improvements that would
otherwise require the size of
Delayto grow further. Since anallocation is already made, the idea is to shrink the size of the
Delaystruct.