Condition unwinding tests on cfg(panic = "unwind")
#5384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriswailes
force-pushed
the
conditional-unwind-tests
branch
from
36ae52f to
1ca4230
Compare
taiki-e
approved these changes
Jan 21, 2023
Member
taiki-e
left a comment
taiki-e
left a comment
There was a problem hiding this comment.
Thanks! cfg(panic) doesn't work on our MSRV (it stabilized on 1.60), but we don't run tests on MSRV, so I think this is ok.
Contributor
|
Yeah, tests aren't subject to the MSRV. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests rely on unwinding and will fail if built with panic-abort.
Motivation
The Rust toolchain for Android is built with panic-abort and these tests will fail without these changes.
Solution
Add a
cfgannotation that only enables these tests ifpanic = "unwind".