ci: run tests on ARM and i686 using cross #5196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllerche
force-pushed
the
github-ci-arm
branch
2 times, most recently
from
13c11b3
to
8c19cf2
Compare
carllerche
force-pushed
the
github-ci-arm
branch
from
e53e4c4
to
ab5a081
Compare
This patch updates CI to use `cross` to run Tokio tests on virtualized ARM and i686 VMs. Because ipv6 doesn't work on Github action running in a docker instance, those tests are disabled
carllerche
force-pushed
the
github-ci-arm
branch
from
ab5a081
to
1b53862
Compare
carllerche
commented
Nov 18, 2022
| use std::sync::Arc; | ||
|
|
||
| for _ in 1..10 { | ||
| let runtime = rt(); | ||
|
|
||
| runtime.block_on(async { | ||
| let socket = UdpSocket::bind((Ipv6Addr::LOCALHOST, 0)).await.unwrap(); | ||
| let socket = UdpSocket::bind("127.0.0.1:0").await.unwrap(); |
There was a problem hiding this comment.
This test doesn't need to use IPv6
carllerche
commented
Nov 18, 2022
| @@ -105,7 +105,7 @@ fn worker_park_count() { | |||
| time::sleep(Duration::from_millis(1)).await; | |||
| }); | |||
| drop(rt); | |||
| assert!(2 <= metrics.worker_park_count(0)); | |||
| assert!(1 <= metrics.worker_park_count(0)); | |||
There was a problem hiding this comment.
There really should only be 1 park in this test, however, there often are more due to #5207. I believe the original test author just included the number they observed when implementing metrics.
carllerche
commented
Nov 18, 2022
| let rx2 = RX2.load(SeqCst); | ||
| assert_eq!(EXPECTED, rx1); | ||
| assert_eq!(EXPECTED, rx2); | ||
| loop { |
There was a problem hiding this comment.
Fixes another timing issue.
Darksonn
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates CI to use
crossto run Tokio tests on virtualizedARM and i686 VMs. Because ipv6 doesn't work on Github action running in
a docker instance, those tests are disabled