Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use setup-cross-toolchain-action instead of cross #4568

Closed
wants to merge 1 commit into from
Closed

ci: use setup-cross-toolchain-action instead of cross #4568

wants to merge 1 commit into from

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Mar 15, 2022

We are currently using cross, which does not work with the tokio test suite.

setup-cross-toolchain-action is a GitHub Action to set up CI environment for cross-testing, including doctest, without dockers.

This allows our CI to run tests for various architectures.

This patch includes:

  • Run test and doctest for aarch64, arm, i686, powerpc64le, mipsel, mips64el, riscv64gc, s390x linux. (Previously, it was build only.)

  • Build for android and aarch64 windows. (setup-cross-toolchain-action doesn't support testing of them)

Closes #3424
Closes #2985 (aarch64 windows)
Closes #4454 (mipsel linux meets this)

@taiki-e taiki-e added the A-ci Area: The continuous integration setup label Mar 15, 2022
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@taiki-e taiki-e marked this pull request as ready for review March 16, 2022 13:08
@taiki-e taiki-e marked this pull request as draft March 16, 2022 15:51
@Darksonn
Copy link
Contributor

What's the status on this?

@carllerche
Copy link
Member

I think we can close this. It looks like cross test works now.

@carllerche carllerche closed this Dec 27, 2022
@carllerche
Copy link
Member

(If I am wrong, we probably should resume work in a new PR at this point).

@taiki-e taiki-e deleted the cross-2 branch September 10, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: The continuous integration setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Windows on ARM64 Compile Tokio on platform without 64-bit atomics
3 participants