v0.1.x: Fix UdpFramed with regards to Decode
#1444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnDoneth
changed the title
UdpFramed with regards to Decode in v0.1.xUdpFramed with regards to Decode
JohnDoneth
changed the title
UdpFramed with regards to DecodeUdpFramed with regard to Decode
JohnDoneth
changed the title
UdpFramed with regard to DecodeUdpFramed with regards to Decode
LucioFranco
approved these changes
Aug 15, 2019
|
@carllerche any idea why we are getting this failure on min supported version? |
|
@LucioFranco Perhaps due to #1369 |
|
@taiki-e ah yeah...I should get to reviewing those PRs. |
|
@JohnDoneth if you still pursuing this PR, try merging with current v0.1.x branch, for hope of passing CI? |
|
@JohnDoneth thanks for this! Is the other PR ready to review/merge into master? |
|
@LucioFranco of course, and yes it's ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should (fix) #1443 in the v0.1.x branch.
UdpFramednow attempts to continue decoding past the first discrete item if there is more data in the read buffer. I added a test for this that sends a packet with 3 lines and tests for the successful decoding of each item in turn.