-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tokio to Rust 2018 #1082
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`await` syntax was implemented in rust-lang/rust#60586, and nightly-2019-05-09 has been released with the changes. Also, `await!` macro will be removed in the future.
ipetkov
reviewed
May 10, 2019
Co-Authored-By: Ivan Petkov <ivanppetkov@gmail.com>
I probably should update doc comments too. |
Ok... this should be good to go. |
I just tried the hyper example and it fails on:
Update: Nevermind, this actually mostly makes sense, as tokio 0.2 is not the same as tokio 0.1 that hyper is using, so hyper is thinking there is no tokio runtime running. |
seanmonstar
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start to what will most likely be the long process of updating Tokio to async / await.
The first step is to update Tokio to use Rust 2018. This also bumps crate versions and sets all crates to
publish = false
.