Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tokio to Rust 2018 #1082

Merged
merged 46 commits into from
May 14, 2019
Merged

Update Tokio to Rust 2018 #1082

merged 46 commits into from
May 14, 2019

Conversation

carllerche
Copy link
Member

This is the start to what will most likely be the long process of updating Tokio to async / await.

The first step is to update Tokio to use Rust 2018. This also bumps crate versions and sets all crates to publish = false.

@carllerche carllerche marked this pull request as ready for review May 10, 2019 20:53
Co-Authored-By: Ivan Petkov <ivanppetkov@gmail.com>
@carllerche
Copy link
Member Author

I probably should update doc comments too.

@carllerche
Copy link
Member Author

Ok... this should be good to go.

@CryZe
Copy link

CryZe commented May 11, 2019

I just tried the hyper example and it fails on:

thread 'tokio-runtime-worker-0' panicked at 'called `Result::unwrap()` on an `Err` value: Error(Inner(Error(User(Execute), "tokio::spawn failed (is a tokio runtime running this future?)")))', src\libcore\result.rs:999:5

Update: Nevermind, this actually mostly makes sense, as tokio 0.2 is not the same as tokio 0.1 that hyper is using, so hyper is thinking there is no tokio runtime running.

@carllerche carllerche merged commit cb4aea3 into master May 14, 2019
@carllerche carllerche deleted the rust-2018 branch May 14, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants