Allow set_nodelay() on TcpSocket
#5510
Labels
A-tokio
Area: The main tokio crate
C-feature-request
Category: A feature request.
M-net
Module: tokio/net
Comments
gregoire-mullvad
added
A-tokio
gregoire-mullvad
changed the title
set_nodelay() on TcpSocketset_nodelay() on TcpSocket
|
This sounds like a fine idea. |
matildasmeds
added a commit
to matildasmeds/tokio
that referenced
this issue
May 3, 2023
We add set_nodelay() and nodelay() methods on the tokio::net::TcpSocket. This way developers can set NODELAY option on the socket directly, without having to acquire the reference to the inner socket2::TcpSocket from tokio::net::TcpStream. Closes tokio-rs#5510
matildasmeds
added a commit
to matildasmeds/tokio
that referenced
this issue
May 3, 2023
We add set_nodelay() and nodelay() methods on the tokio::net::TcpSocket. This way developers can set NODELAY option on the socket directly, without having to resort for workarounds, as described on the original issue.. Closes tokio-rs#5510
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
It's a bit cumbersome to have to set some options on
TcpSocketand others onTcpStream. It would be nice to be able to set all the option onTcpSocketinstead. When using aTcpListenerthis would also mean I only need to set the option once, instead of having to do it on every incoming connection.Describe the solution you'd like
Add
TcpSocket::set_nodelay()(and the corresponding getter,TcpSocket::nodelay().)Describe alternatives you've considered
I know this is already possible to do by using
socket2to set the option withSockRef::from(&tokio_tcp_socket).set_nodelay(), but that solution is not obvious and require adding an other (direct) dependency to the project. (One also need to be careful to use a compatible version of socket2.)The text was updated successfully, but these errors were encountered: