Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn benchmark problems #3904

Open
Darksonn opened this issue Jun 30, 2021 · 4 comments
Open

Spawn benchmark problems #3904

Darksonn opened this issue Jun 30, 2021 · 4 comments
Labels
A-benches Area: Benchmarks E-help-wanted Call for participation: Help is requested to fix this issue. M-runtime Module: tokio/runtime

Comments

@Darksonn
Copy link
Contributor

The spawning benchmarks in benches/spawn.rs seem to be rather poor:

  1. The spawned tasks are not awaited, so spawns from one iteration may still be consuming resources during the next benchmark iteration.
  2. The threaded_scheduler_local_spawn benchmark uses a basic scheduler and is identical to the basic_scheduler_local_spawn benchmark.
  3. The basic_scheduler_remote_spawn benchmark doesn't use block_on, so the spawned tasks do not run, whereas they do run in other benchmarks.
@Darksonn Darksonn added M-runtime Module: tokio/runtime A-benches Area: Benchmarks labels Jun 30, 2021
@Darksonn Darksonn added the E-help-wanted Call for participation: Help is requested to fix this issue. label Sep 19, 2021
@Wizdave97
Copy link

@Darksonn I would love to help with this, any pointers on where to start?

@Darksonn
Copy link
Contributor Author

Well, come up with some better ways to test them, then modify the files as appropriate. You should be able to run them by running cargo bench from the benches/ directory.

If you have more questions on how to approach this, I would encourage you to join the Tokio discord where I would be happy to give you some pointers in the right direction.

@xudong963
Copy link
Contributor

Hi @Wizdave97, how's this going? If you are busy with other things, I want to try it! /cc @Darksonn

@Wizdave97
Copy link

Hi @Wizdave97, how's this going? If you are busy with other things, I want to try it! /cc @Darksonn

Yeah you can take a stab at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-benches Area: Benchmarks E-help-wanted Call for participation: Help is requested to fix this issue. M-runtime Module: tokio/runtime
Projects
None yet
Development

No branches or pull requests

3 participants