Skip to content

Commit

Permalink
ci: remove cargo-semver-checks flags that are no longer necessary (#5496
Browse files Browse the repository at this point in the history
)

These flags were previously only needed due to a bug in the `cargo-semver-checks` CLI logic.

The correct behavior (available as of v0.18.3) for `cargo-semver-checks` is to ignore `publish = false` crates when scanning a workspace, *unless* those crates are specifically selected for checking.

All the crates being excluded here are `publish = false` so they are already excluded by the default behavior, so all `--exclude` flags are no-ops.
  • Loading branch information
obi1kenobi authored Feb 22, 2023
1 parent d7b7c61 commit cf48636
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -245,13 +245,7 @@ jobs:
tool: cargo-semver-checks
- name: Check semver compatibility
run: |
cargo semver-checks check-release \
--release-type minor \
--exclude benches \
--exclude examples \
--exclude stress-test \
--exclude tests-build \
--exclude tests-integration
cargo semver-checks check-release --release-type minor
cross-check:
name: cross-check
Expand Down

0 comments on commit cf48636

Please sign in to comment.