feat: add support for vsock connections #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hey! This looks good in general. Would you mind adding a bit more background and justification to your PR message (that will go into the commit history). Basically because I didn't know what a vsock was until today, so I figure the reference would be worthwhile. 😅 |
Contributor
Author
|
@hds done :) |
Contributor
Author
|
Friendly ping :) |
Collaborator
|
@domenkozar Thanks for the ping. I've just had another look through the PR, however don't we need to add vsock support into tokio-console as well? Otherwise this feels like only half the feature. |
Contributor
Author
|
@hds something like this? :) |
hds
requested changes
Apr 14, 2025
Collaborator
hds
left a comment
hds
left a comment
There was a problem hiding this comment.
Looks good! Just a few small things regarding error handling (mostly in the case where the new feature isn't enabled).
Contributor
Author
|
PTAL :) |
hds
approved these changes
Apr 14, 2025
Collaborator
hds
left a comment
hds
left a comment
There was a problem hiding this comment.
Looks good. Just a couple of CI checks that are failing. Thanks for all your work on this PR!
hds
changed the title
This allows connecting to VSOCK address family, which is used in VMs: https://man7.org/linux/man-pages/man7/vsock.7.html
Collaborator
|
@domenkozar Merged! Thanks for your contribution! I hope to get a release of the crates out in the next week. There are just a few little changes that we'd like to make first. |
Closed
hds
pushed a commit
that referenced
this pull request
Oct 29, 2025
…onsole-v0.1.14 # console-api ## 0.9.0 - (2025-10-29) ### <a id = "0.9.0-breaking"></a>Breaking Changes - **Upgrade tonic to 0.13 ([#615](#615 ([2bd1afd](https://github.com/tokio-rs/console/commit/2bd1afda7987dea0505d231d9ce8bf109e5f7a96))<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.12.x. - **Upgrade tonic to 0.14 ([#642](https://github.com/tokio-rs/console/issues/642))**<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.13.x. ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) ### Fixed - Bump minimum version of tonic ([#593](#593)) ([1f41b61](1f41b61), closes [#592](#592), closes [#592](#592)) ### Updated - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.14 ([#645](#645)) # console-subscriber ## 0.5.0 - (2025-10-29) ### <a id = "0.5.0-breaking"></a>Breaking Changes - **Upgrade tonic to 0.13 ([#615](#615 ([2bd1afd](https://github.com/tokio-rs/console/commit/2bd1afda7987dea0505d231d9ce8bf109e5f7a96))<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.12.x. - **Upgrade tonic to 0.14 ([#642](https://github.com/tokio-rs/console/issues/642))**<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.13.x. ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) - Add support for vsock connections ([#623](#623)) ([63c70ee](63c70ee)) ### Documented - Fix typo in doc comment ([3dbca7a](3dbca7a)) ### Updated - [**breaking**](#0.5.0-breaking) Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.14 ([#645](#645)) # tokio-console ## 0.1.14 - (2025-10-29) ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) - Improve error msg when state streaming API is unimplemented ([#598](#598)) ([6ef148a](6ef148a)) - Add support for vsock connections ([#623](#623)) ([63c70ee](63c70ee)) ### Fixed - Add dynamic constraints layout in task details screen ([#614](#614)) ([ada7dab](ada7dab), fixes [#523](#523), fixes [#523](#523)) ### Updated - Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - Upgrade tonic to 0.14 ([#645](#645))
hds
pushed a commit
that referenced
this pull request
Oct 29, 2025
…onsole-v0.1.14 # console-api ## 0.9.0 - (2025-10-29) ### <a id = "0.9.0-breaking"></a>Breaking Changes - **Upgrade tonic to 0.13 ([#615](#615 ([2bd1afd](https://github.com/tokio-rs/console/commit/2bd1afda7987dea0505d231d9ce8bf109e5f7a96))<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.12.x. - **Upgrade tonic to 0.14 ([#642](https://github.com/tokio-rs/console/issues/642))**<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.13.x. ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) ### Fixed - Bump minimum version of tonic ([#593](#593)) ([1f41b61](1f41b61), closes [#592](#592), closes [#592](#592)) ### Updated - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.14 ([#645](#645)) # console-subscriber ## 0.5.0 - (2025-10-29) ### <a id = "0.5.0-breaking"></a>Breaking Changes - **Upgrade tonic to 0.13 ([#615](#615 ([2bd1afd](https://github.com/tokio-rs/console/commit/2bd1afda7987dea0505d231d9ce8bf109e5f7a96))<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.12.x. - **Upgrade tonic to 0.14 ([#642](https://github.com/tokio-rs/console/issues/642))**<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.13.x. ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) - Add support for vsock connections ([#623](#623)) ([63c70ee](63c70ee)) ### Documented - Fix typo in doc comment ([3dbca7a](3dbca7a)) ### Updated - [**breaking**](#0.5.0-breaking) Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.14 ([#645](#645)) # tokio-console ## 0.1.14 - (2025-10-29) ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) - Improve error msg when state streaming API is unimplemented ([#598](#598)) ([6ef148a](6ef148a)) - Add support for vsock connections ([#623](#623)) ([63c70ee](63c70ee)) ### Fixed - Add dynamic constraints layout in task details screen ([#614](#614)) ([ada7dab](ada7dab), fixes [#523](#523), fixes [#523](#523)) ### Updated - Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - Upgrade tonic to 0.14 ([#645](#645))
hds
pushed a commit
that referenced
this pull request
Oct 30, 2025
…onsole-v0.1.14 # console-api ## 0.9.0 - (2025-10-30) ### <a id = "0.9.0-breaking"></a>Breaking Changes - **Upgrade tonic to 0.13 ([#615](#615 ([2bd1afd](https://github.com/tokio-rs/console/commit/2bd1afda7987dea0505d231d9ce8bf109e5f7a96))<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.12.x. - **Upgrade tonic to 0.14 ([#642](https://github.com/tokio-rs/console/issues/642))**<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.13.x. ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) ### Fixed - Bump minimum version of tonic ([#593](#593)) ([1f41b61](1f41b61), closes [#592](#592), closes [#592](#592)) ### Updated - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.14 ([#645](#645)) # console-subscriber ## 0.5.0 - (2025-10-30) ### <a id = "0.5.0-breaking"></a>Breaking Changes - **Upgrade tonic to 0.13 ([#615](#615 ([2bd1afd](https://github.com/tokio-rs/console/commit/2bd1afda7987dea0505d231d9ce8bf109e5f7a96))<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.12.x. - **Upgrade tonic to 0.14 ([#642](https://github.com/tokio-rs/console/issues/642))**<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.13.x. ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) - Add support for vsock connections ([#623](#623)) ([63c70ee](63c70ee)) ### Documented - Fix typo in doc comment ([3dbca7a](3dbca7a)) ### Updated - [**breaking**](#0.5.0-breaking) Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.14 ([#645](#645)) # tokio-console ## 0.1.14 - (2025-10-30) ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) - Improve error msg when state streaming API is unimplemented ([#598](#598)) ([6ef148a](6ef148a)) - Add support for vsock connections ([#623](#623)) ([63c70ee](63c70ee)) ### Fixed - Add dynamic constraints layout in task details screen ([#614](#614)) ([ada7dab](ada7dab), fixes [#523](#523), fixes [#523](#523)) ### Updated - Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - Upgrade tonic to 0.14 ([#645](#645))
hds
pushed a commit
that referenced
this pull request
Oct 30, 2025
…onsole-v0.1.14 (#648) # console-api ## 0.9.0 - (2025-10-30) ### <a id = "0.9.0-breaking"></a>Breaking Changes - **Upgrade tonic to 0.13 ([#615](#615 ([2bd1afd](https://github.com/tokio-rs/console/commit/2bd1afda7987dea0505d231d9ce8bf109e5f7a96))<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.12.x. - **Upgrade tonic to 0.14 ([#642](https://github.com/tokio-rs/console/issues/642))**<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.13.x. ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) ### Fixed - Bump minimum version of tonic ([#593](#593)) ([1f41b61](1f41b61), closes [#592](#592), closes [#592](#592)) ### Updated - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.14 ([#645](#645)) # console-subscriber ## 0.5.0 - (2025-10-30) ### <a id = "0.5.0-breaking"></a>Breaking Changes - **Upgrade tonic to 0.13 ([#615](#615 ([2bd1afd](https://github.com/tokio-rs/console/commit/2bd1afda7987dea0505d231d9ce8bf109e5f7a96))<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.12.x. - **Upgrade tonic to 0.14 ([#642](https://github.com/tokio-rs/console/issues/642))**<br />This is a breaking change for users of `console-api` and `console-subscriber`, as it changes the public `tonic` dependency to a semver-incompatible version. This breaks compatibility with `tonic` 0.13.x. ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) - Add support for vsock connections ([#623](#623)) ([63c70ee](63c70ee)) ### Documented - Fix typo in doc comment ([3dbca7a](3dbca7a)) ### Updated - [**breaking**](#0.5.0-breaking) Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - [**breaking**](#0.9.0-breaking) Upgrade tonic to 0.14 ([#645](#645)) # tokio-console ## 0.1.14 - (2025-10-30) ### Added - Add the WatchState API ([#582](#582)) ([7c1f9f2](7c1f9f2)) - Improve error msg when state streaming API is unimplemented ([#598](#598)) ([6ef148a](6ef148a)) - Add support for vsock connections ([#623](#623)) ([63c70ee](63c70ee)) ### Fixed - Add dynamic constraints layout in task details screen ([#614](#614)) ([ada7dab](ada7dab), fixes [#523](#523), fixes [#523](#523)) ### Updated - Upgrade tonic to 0.13 ([#615](#615)) ([2bd1afd](2bd1afd)) - Upgrade tonic to 0.14 ([#645](#645)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've hidden it behind a feature flag, since it's kind of uncommon.