Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release axum 0.7.8 and axum-extra 0.9.5 #3028

Merged
merged 23 commits into from
Nov 15, 2024
Merged

Release axum 0.7.8 and axum-extra 0.9.5 #3028

merged 23 commits into from
Nov 15, 2024

Conversation

jplatte
Copy link
Member

@jplatte jplatte commented Nov 14, 2024

The diff on this PR shows what's going to be merged back into main after the release of these two crates. The actual diff is here: axum-v0.7.7...feee742

Of particular note is 0d4e224, which I've had to change a bunch to work / compile. All the same test adjustments are made though, and the tests pass on the v0.7.x branch.

Do not merge via GitHub UI

Same release process as last time, though I also ran tests locally since this PR doesn't actually test the v0.7.x branch.

Copy link
Collaborator

@yanns yanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the version numbers and they're correct.
I don't know how the release process works to be honest. Most of those changes are already on main also I don't know why they will be merged into main again. Feel free to process.
I guess you cherry-picked all those changes on the 0.7.x branch, and that's why they're shown. But merging this won't actually change main much, just add a merge commit with parent on the new 0.7.x branch.

@jplatte
Copy link
Member Author

jplatte commented Nov 15, 2024

Yeah, I cherry-picked changes and posted the actual diff view above for review. I like merging back release branches into main as a way of syncing up the changelog and to detect any unexpected changes on the release branch.

@jplatte jplatte merged commit dee0985 into main Nov 15, 2024
18 checks passed
@jplatte jplatte deleted the jplatte/merge-v0.7.8 branch November 15, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.