Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Fix compile errors from __log_rejection #2933

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

jplatte
Copy link
Member

@jplatte jplatte commented Sep 24, 2024

Motivation

It was failing to compile if axum-core's tracing feature was enabled, but the tracing feature of axum or axum-extra wasn't when those were part of the dependency tree.

Solution

Use a private re-export, as commonly done with macros that need to refer to some other crate at the expansion site.

Fixes #2932.

It was failing to compile if axum-core's tracing feature was enabled,
but the tracing feature of axum or axum-extra wasn't when those were
part of the dependency tree.
@jplatte jplatte merged commit 391f2de into main Sep 25, 2024
18 checks passed
@jplatte jplatte deleted the jplatte/tracing-fix branch September 25, 2024 07:44
Lachstec pushed a commit to Lachstec/axum that referenced this pull request Oct 11, 2024
Lachstec pushed a commit to Lachstec/axum that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to resolve: use of undeclared crate or module tracing
2 participants