Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give better error if generics are used with #[derive(FromRef)] #1874

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Give better error if generics are used with #[derive(FromRef)] #1874

merged 2 commits into from
Mar 22, 2023

Conversation

davidpdrsn
Copy link
Member

Generics gives overlapping impls.

@davidpdrsn davidpdrsn added C-enhancement Category: A PR with an enhancement A-axum-macros labels Mar 22, 2023
@davidpdrsn davidpdrsn requested a review from jplatte March 22, 2023 13:31
@davidpdrsn davidpdrsn merged commit cfb5df7 into main Mar 22, 2023
@davidpdrsn davidpdrsn deleted the david/from-ref-generics-error branch March 22, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
A-axum-macros C-enhancement Category: A PR with an enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidpdrsn @jplatte