Skip to content

Optionals, nullables, and iterables, oh my! #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kainino0x merged 3 commits into from
Mar 24, 2025
Merged

Optionals, nullables, and iterables, oh my! #1

kainino0x merged 3 commits into from
Mar 24, 2025

Conversation

@kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Mar 22, 2025 •
edited
Loading

  • Correctly handle optional args before required args
  • Translate nullable inputs as T|undefined|null
  • Translate sequence as Iterable instead of Array. Works because:

    WebGPU doesn't actually use any output sequences (IIRC), instead using FrozenArray (which as of today it only uses in one place).

Fixes darionco/bikeshed-to-ts#6

@kainino0x kainino0x mentioned this pull request Mar 22, 2025
Closed
@kainino0x kainino0x force-pushed the optionals-nullables-iterables branch from 0fc1065 to 9596655 Compare March 22, 2025 03:52
kainino0x added a commit to toji/bikeshed-to-ts that referenced this pull request Mar 22, 2025
@kainino0x
Pin webidl2ts revision to toji/webidl2ts#1
f63a03d
@kainino0x kainino0x mentioned this pull request Mar 22, 2025
Draft
@kainino0x kainino0x merged commit 9596655 into toji:master Mar 24, 2025
@kainino0x kainino0x deleted the optionals-nullables-iterables branch March 24, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

IDL sequence should be Iterable, not Array

1 participant

@kainino0x