Add mat4.perspectiveZO, mat4.orthoZO for WebGPU #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evice coordinates
kainino0x
approved these changes
Jan 12, 2021
|
perspectiveFieldOfView is planned to be deprecated and removed. You're right that ortho will need the same thing, though. |
|
Added the ortho version. |
toji
changed the title
kainino0x
approved these changes
Jan 12, 2021
|
You missed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting this up as a pull request in case there's any feedback.
The upcoming WebGPU API uses Normalized Device Coordinates with a [0, 1] Z range, which differs from WebGL's [-1, 1] range. To get the best precision out of WebGPU pages will need to create perspective matrices a bit differently.
This change introduces the
mat4.perspectiveZO(), which is identical in functionality to the previousmat4.perspective()method except it maps to the [0, -1] range. For consistency the previous method has been renamed tomat4.perspectiveNO()with an alias ofmat4.perspective(). This could later allow users to configure the library to use one projection method or the other by default. Naming convention borrowed from the native glm library because I can't think of anything better that doesn't end up with 50 character long method names.