Merge pull request #430 from munsocket/master

Optimize angle(v1, v2)
toji · Jun 2, 2021 · be9e9b5 · be9e9b5
2 parents fccd5f7 + 07e80bf
commit be9e9b5
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/src/vec3.js b/src/vec3.js
@@ -675,9 +675,7 @@ export function angle(a, b) {
     bx = b[0],
     by = b[1],
     bz = b[2],
-    mag1 = Math.sqrt(ax * ax + ay * ay + az * az),
-    mag2 = Math.sqrt(bx * bx + by * by + bz * bz),
-    mag = mag1 * mag2,
+    mag = Math.sqrt((ax * ax + ay * ay + az * az) * (bx * bx + by * by + bz * bz)),
     cosine = mag && dot(a, b) / mag;
   return Math.acos(Math.min(Math.max(cosine, -1), 1));
 }