Added the ability to query by widget id#149
Open
BrooksPatton wants to merge 1 commit intotogglebyte:devfrom
Open
Added the ability to query by widget id#149BrooksPatton wants to merge 1 commit intotogglebyte:devfrom
BrooksPatton wants to merge 1 commit intotogglebyte:devfrom
Conversation
|
Quick summary i wrote on @BrooksPatton 's stream for this pr, just posting it here for completeness :) Summary
In support of that
MotivationSome actions (e.g. focus) are only available for deferred components, an sometimes we wish to execute them on the current or a child component. As such the following pattern seems desirable: let my_id = context.widget_id;
// or
let my_id = children.components().by_name("...")....;
context.components.by_id(my_id).focus() |
Author
|
Thanks Justus! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a QueryFilter option by_id which takes in a WidgetId. This is helpful especially if we want to focus on our own component from our component.
Example, we check if we've been clicked on, and if so focus on ourselves.
I didn't see any automated tests in this section so I didn't add any.