Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): peek view animation use zoom when possible #8793

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Nov 12, 2024

fix AF-1667

Copy link

graphite-app bot commented Nov 12, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Nov 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Nov 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 01d1631. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.87%. Comparing base (b5fa847) to head (01d1631).
Report is 4 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8793      +/-   ##
==========================================
+ Coverage   70.25%   70.87%   +0.61%     
==========================================
  Files         549      549              
  Lines       33900    33900              
  Branches     3044     3082      +38     
==========================================
+ Hits        23817    24027     +210     
+ Misses       9712     9499     -213     
- Partials      371      374       +3     
Flag Coverage Δ
server-test 77.90% <ø> (+0.71%) ⬆️
unittest 45.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/11-12-fix_core_peek_view_animation_use_zoom_when_possible branch from 9470ba2 to d322e9b Compare November 12, 2024 09:17
Copy link

graphite-app bot commented Nov 13, 2024

Merge activity

@pengx17 pengx17 force-pushed the xp/11-12-fix_core_peek_view_animation_use_zoom_when_possible branch from d322e9b to 01d1631 Compare November 13, 2024 02:40
@graphite-app graphite-app bot merged commit 01d1631 into canary Nov 13, 2024
46 checks passed
@graphite-app graphite-app bot deleted the xp/11-12-fix_core_peek_view_animation_use_zoom_when_possible branch November 13, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants