Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new login flow #8387

Open
wants to merge 12 commits into
base: canary
Choose a base branch
from
Open

feat: new login flow #8387

wants to merge 12 commits into from

Conversation

darkskygit
Copy link
Member

fix AF-1406

@graphite-app graphite-app bot requested review from Brooooooklyn, pengx17, forehalo, EYHN and JimmFly and removed request for JimmFly September 25, 2024 08:07
Copy link

graphite-app bot commented Sep 25, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @darkskygit and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Sep 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 12b12d4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 52.15686% with 122 lines in your changes missing coverage. Please review.

Project coverage is 70.65%. Comparing base (bfc8b93) to head (12b12d4).

Files with missing lines Patch % Lines
...ges/backend/server/src/plugins/oauth/controller.ts 46.87% 119 Missing ⚠️
packages/frontend/core/src/utils/channel.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8387      +/-   ##
==========================================
+ Coverage   70.20%   70.65%   +0.45%     
==========================================
  Files         549      549              
  Lines       33891    34095     +204     
  Branches     3042     3087      +45     
==========================================
+ Hits        23794    24091     +297     
+ Misses       9727     9654      -73     
+ Partials      370      350      -20     
Flag Coverage Δ
server-test 77.56% <52.58%> (+0.44%) ⬆️
unittest 45.88% <25.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants