Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infra): doc properties by orm #8382

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Sep 25, 2024

create new orm table docConfiguration

move primary store to docConfiguration

Copy link

graphite-app bot commented Sep 25, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@EYHN EYHN marked this pull request as ready for review September 25, 2024 02:32
@github-actions github-actions bot added the mod:infra Environment related issues and discussions label Sep 25, 2024
Copy link
Member Author

EYHN commented Sep 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Sep 25, 2024

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 14.87603% with 103 lines in your changes missing coverage. Please review.

Project coverage is 70.09%. Comparing base (f5c49a6) to head (c26df2e).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...mon/infra/src/modules/doc/stores/doc-properties.ts 0.00% 45 Missing ⚠️
packages/common/infra/src/utils/yjs-observable.ts 40.00% 24 Missing and 3 partials ⚠️
...ckages/common/infra/src/modules/doc/stores/docs.ts 0.00% 25 Missing ⚠️
...on/infra/src/modules/doc/entities/property-list.ts 0.00% 4 Missing ⚠️
...es/common/infra/src/modules/doc/entities/record.ts 0.00% 1 Missing ⚠️
.../infra/src/modules/workspace/entities/workspace.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8382      +/-   ##
==========================================
- Coverage   70.28%   70.09%   -0.20%     
==========================================
  Files         520      523       +3     
  Lines       32961    33051      +90     
  Branches     2879     2902      +23     
==========================================
- Hits        23167    23166       -1     
- Misses       9455     9543      +88     
- Partials      339      342       +3     
Flag Coverage Δ
server-test 76.71% <ø> (-0.07%) ⬇️
unittest 45.71% <14.87%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN marked this pull request as draft September 26, 2024 16:57
@EYHN EYHN changed the title feat(infra): doc configuration feat(infra): doc properties by orm Sep 27, 2024
@github-actions github-actions bot added the test Related to test cases label Sep 27, 2024
@EYHN EYHN marked this pull request as ready for review September 27, 2024 09:32
@EYHN EYHN requested a review from pengx17 September 27, 2024 09:32
@EYHN EYHN force-pushed the eyhn/doc-configuration branch 2 times, most recently from da29f9f to d28dece Compare September 27, 2024 09:56
Copy link

graphite-app bot commented Oct 7, 2024

Merge activity

create new orm table docConfiguration

move primary store to docConfiguration
@graphite-app graphite-app bot merged commit c26df2e into canary Oct 7, 2024
38 checks passed
@graphite-app graphite-app bot deleted the eyhn/doc-configuration branch October 7, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:infra Environment related issues and discussions test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants