Open
Conversation
|
|
Contributor
|
Important Review skippedToo many files! This PR contains 232 files, which is 82 over the limit of 150. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (13)
📒 Files selected for processing (232)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
Nice feature enhancement, but I think this PR is too large, making it difficult to review |
Add connector routing/jumps, expanded shape libraries, grid and snap controls, properties panel improvements, and export/import coverage for edgeless workflows, with new integration and e2e tests.
spmp
force-pushed
the
feature/advanced-diagramming-capability-merged
branch
from
758f76d to
794dfad
Compare
Author
|
Thank you @darkskygit for taking the time to review and consider this PR. I see that I must have n00bed the merge with canary as all merge edits were included in this PR. I am happy to break into smaller PR's - it's some work and happy to do it if y'all are serious about considering this for inclusion. I propose the following PR:
Keen to hear your thoughts. |
Member
I think enhancing the connector is a great start. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagramming power-up - Drawio like diagramming native to AFFiNE
I built this to make AFFiNE edgeless viable for my day-to-day diagramming workflow (draw.io-like use cases) without switching tools for text, structure, and export/import.
I know this is a large change set and that reviewing it will require real effort. I want to explicitly acknowledge that up front.
Please see #14471 for a detailed view.
What this PR adds
Validation status
I’ve run extensive test work across unit/integration/e2e while building this and tracked feature coverage + known failures in the related GitHub discussion thread (including rerun notes and failing cases).
There are still failures in the broader suite; some appear to reproduce on upstream/canary as baseline instability, not only from this branch.
Maintainer expectations
I understand this is not a “quick review” PR.
If you’re open to it, I can do whatever reduces your review burden:
I’m committed to working through review feedback with you, including iterative follow-up PRs until this is in a shape you’re comfortable with.
Vibe AF
Almost entirely vibe coded with Claude and Codex
Enjoy
🤗