Update versions of node in ci. Fixes ci. #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8 and 19 closes: todogroup#270 Signed-off-by: Jeroen Knoops <jeroen.knoops@philips.com>
Signed-off-by: Jeroen Knoops <jeroen.knoops@philips.com>
|
Error in docker test will be resolved in #281 |
JeroenKnoops
changed the title
JeroenKnoops
added a commit
to philips-forks/repolinter
that referenced
this pull request
Feb 24, 2023
Changes as done in todogroup#280 Signed-off-by: Jeroen Knoops <jeroen.knoops@philips.com>
|
Thank you Jeroen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Update to supported versions of node.
Currently node 14, 16 and 18 are stable. See https://github.com/nodejs/release#release-schedule
Also added v19.6.1, because we're using
node:busterin theDockerfilewhich uses v19.6.1.Proposed Changes
This PR will:
Test Plan
Ran tests (
npm ci,npm test,npm apidoc) on macOs for:Related issue
closes: #270